Use Compound ListRow instead of Compound form styles. #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 2bc09a5 |
pixlwave
changed the title
.xyzStyle(.compoundRow)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1484 +/- ##
===========================================
- Coverage 52.89% 52.28% -0.62%
===========================================
Files 404 404
Lines 27127 27061 -66
Branches 13548 13513 -35
===========================================
- Hits 14348 14148 -200
- Misses 12369 12511 +142
+ Partials 410 402 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pixlwave
force-pushed
the
doug/compound-list
branch
from
fc74ec0 to
334b543
Compare
To check: - Pseudo Bug Report Attach Screenshot label - Bug Report screenshot padding (Use ListRow .custom?) - De-bold Analytics & Notification Settings footer links - Inline picker alignment perhaps?
pixlwave
force-pushed
the
doug/compound-list
branch
from
334b543 to
2bc09a5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Velin92
reviewed
Aug 16, 2023
UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.templateScreen.png
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the new
ListRowcomponent replacing.xyzStyle(.compoundForm)in all the screens it was used. There are still remaining screens using the older EX form styles which I will look at in a separate PR.Additionally there are refinements to make to the component (as noted in the snapshots commit), but this gets everything merged to try and avoid any conflicts with other branches.