Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for voice over reading the braille dot #1538

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 22, 2023

We use a braille dot in app to get some extra spacing for the timestamp, however I just discovered that the voice over reads it.

This small fix solves the problem by overriding the accessibility with the original attributed string instead of the adjusted one.

@Velin92 Velin92 requested a review from a team as a code owner August 22, 2023 11:18
@Velin92 Velin92 requested review from stefanceriu and removed request for a team August 22, 2023 11:18
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7f0d286

@Velin92 Velin92 enabled auto-merge (squash) August 22, 2023 11:43
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.36% 🎉

Comparison is base (b1ea23c) 52.94% compared to head (7a80326) 53.31%.

❗ Current head 7a80326 differs from pull request most recent head 7f0d286. Consider uploading reports for the commit 7f0d286 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1538      +/-   ##
===========================================
+ Coverage    52.94%   53.31%   +0.36%     
===========================================
  Files          405      402       -3     
  Lines        26928    26631     -297     
  Branches     13373    13249     -124     
===========================================
- Hits         14257    14198      -59     
+ Misses       12291    12055     -236     
+ Partials       380      378       -2     
Flag Coverage Δ
unittests 23.05% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/RoomScreen/View/Timeline/FormattedBodyText.swift 37.50% <0.00%> (-1.05%) ⬇️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🙌

@Velin92 Velin92 force-pushed the mauroromito/voice_reads_braille branch from 7a80326 to 7f0d286 Compare August 22, 2023 13:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit 4c33d9a into develop Aug 22, 2023
@Velin92 Velin92 deleted the mauroromito/voice_reads_braille branch August 22, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants