Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks for CI #157

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Small tweaks for CI #157

merged 2 commits into from
Aug 4, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 3, 2022

This PR makes 2 small tweaks for CI:

  • Danger is now disabled for external repos as it fails due to the missing GH secret.
  • SwiftFormat is run as a pre-build script to fail early and free up runners quicker.

Simplify the check for the alpha release to reduce number of jobs.
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 57f5702

@pixlwave pixlwave marked this pull request as ready for review August 3, 2022 11:20
@pixlwave pixlwave requested a review from ismailgulek August 3, 2022 11:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YrdcoR

@codecov-commenter
Copy link

Codecov Report

Merging #157 (57f5702) into develop (a3d2fc4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #157   +/-   ##
========================================
  Coverage    35.01%   35.01%           
========================================
  Files          168      168           
  Lines        11739    11739           
  Branches      5747     5746    -1     
========================================
  Hits          4110     4110           
  Misses        7537     7537           
  Partials        92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d2fc4...57f5702. Read the comment docs.

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixlwave pixlwave merged commit b4caaa6 into develop Aug 4, 2022
@pixlwave pixlwave deleted the doug/ci-tweaks branch August 4, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants