Use Safari for OIDC account URL. #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/oidc-safari
branch
from
3d05cc3 to
6d9ee59
Compare
Generated by 🚫 Danger Swift against 60145c5 |
Only used on devices, the simulator doesn't work properly.
pixlwave
force-pushed
the
doug/oidc-safari
branch
from
6d9ee59 to
ca084fa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from matrix-org/matrix-authentication-service#1598, cookies are now correctly shared from the
ASWebAuthenticationSessionto Safari. As requested by the auth team, we now open the account URL in Safari. The WAS is still used in the follow scenarios:Additionally, this PR will present RP-Initiated Logout to the user when returned by the authentication issuer (untested).