Initial skeleton for Universal Link handling. #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
requested review from
alfogrillo and
stefanceriu
and removed request for
a team and
alfogrillo
Generated by 🚫 Danger Swift against bc3d4b8 |
pixlwave
force-pushed
the
doug/universal-link-handling
branch
from
4a1bb07 to
bc3d4b8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1638 +/- ##
===========================================
- Coverage 57.91% 57.86% -0.05%
===========================================
Files 411 411
Lines 28074 28076 +2
Branches 14000 14000
===========================================
- Hits 16258 16246 -12
- Misses 11372 11384 +12
- Partials 444 446 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
stefanceriu
reviewed
Sep 6, 2023
| @@ -132,6 +135,15 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationCoordinatorDelegate, | |||
| ) | |||
| } | |||
|
|
|||
| func handleUniversalLink(_ url: URL) { | |||
There was a problem hiding this comment.
I wonder if we should rename this to just handleURL as it should probably handle non-universal links too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the initial implementation for receiving Universal Links into the App Coordinator. It doesn't implement parsing
AppRoutes from the links or do anything with them yet though.Additionally it removes all use of
ServiceLocator.shared.settingsin the App Coordinator.@stefanceriu You're welcome to merge this tomorrow morning if you're happy with it and need to use it.