Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping on room link (with roomID) #1853

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 3, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 3be16e4

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b0f4fc1) 71.41% compared to head (6546c13) 71.29%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1853      +/-   ##
===========================================
- Coverage    71.41%   71.29%   -0.12%     
===========================================
  Files          442      442              
  Lines        30091    30092       +1     
  Branches     14751    14753       +2     
===========================================
- Hits         21488    21454      -34     
- Misses        8063     8101      +38     
+ Partials       540      537       -3     
Flag Coverage Δ
unittests 54.79% <66.66%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntX/Sources/Application/Navigation/AppRoutes.swift 93.75% <100.00%> (+0.09%) ⬆️
ElementX/Sources/Application/AppCoordinator.swift 54.62% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 marked this pull request as ready for review October 3, 2023 16:36
@Velin92 Velin92 requested a review from a team as a code owner October 3, 2023 16:36
@Velin92 Velin92 requested review from stefanceriu and removed request for a team October 3, 2023 16:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👏

@Velin92 Velin92 merged commit dce94e7 into develop Oct 4, 2023
@Velin92 Velin92 deleted the mauroromito/tapping_on_room_links branch October 4, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants