-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial service implementation for using a PIN code. #1912
Conversation
8115884
to
6632182
Compare
Generated by 🚫 Danger Swift against 3b80b09 |
600-800 lines is perfectly normal for our PRs, up it to 1000.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1912 +/- ##
========================================
Coverage 69.31% 69.32%
========================================
Files 480 481 +1
Lines 32776 32871 +95
Branches 15924 15969 +45
========================================
+ Hits 22720 22788 +68
- Misses 9470 9495 +25
- Partials 586 588 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Kudos, SonarCloud Quality Gate passed!
|
This PR implements the AppLockService for PIN codes, storing them in the keychain and allowing a grace period for when the app should be unlocked. It does not include TouchID/FaceID support yet, nor is there any UI yet.