Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial service implementation for using a PIN code. #1912

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 17, 2023

This PR implements the AppLockService for PIN codes, storing them in the keychain and allowing a grace period for when the app should be unlocked. It does not include TouchID/FaceID support yet, nor is there any UI yet.

@pixlwave pixlwave requested a review from a team as a code owner October 17, 2023 11:48
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 17, 2023 11:48
@pixlwave pixlwave force-pushed the doug/app-lock-service branch from 8115884 to 6632182 Compare October 17, 2023 11:49
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 3b80b09

600-800 lines is perfectly normal for our PRs, up it to 1000.
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (6e8dff2) 69.31% compared to head (7028490) 69.32%.
Report is 2 commits behind head on develop.

❗ Current head 7028490 differs from pull request most recent head 3b80b09. Consider uploading reports for the commit 3b80b09 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1912   +/-   ##
========================================
  Coverage    69.31%   69.32%           
========================================
  Files          480      481    +1     
  Lines        32776    32871   +95     
  Branches     15924    15969   +45     
========================================
+ Hits         22720    22788   +68     
- Misses        9470     9495   +25     
- Partials       586      588    +2     
Flag Coverage Δ
unittests 54.48% <72.47%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ElementX/Sources/Application/AppSettings.swift 95.45% <100.00%> (+0.14%) ⬆️
...ementX/Sources/Services/AppLock/AppLockTimer.swift 100.00% <100.00%> (ø)
...Sources/Services/Keychain/KeychainController.swift 65.65% <78.57%> (+3.53%) ⬆️
...entX/Sources/Services/AppLock/AppLockService.swift 56.00% <48.78%> (-1.15%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

ElementX/Sources/Services/AppLock/AppLockService.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/AppLock/AppLockTimer.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/AppLock/AppLockTimer.swift Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave merged commit 99c2878 into develop Oct 19, 2023
@pixlwave pixlwave deleted the doug/app-lock-service branch October 19, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants