Add App Lock settings screen #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 28669e3 |
pixlwave
force-pushed
the
doug/app-lock-settings
branch
from
dd7f9d7 to
9cbd1ec
Compare
stefanceriu
approved these changes
Oct 18, 2023
ElementX/Sources/Screens/AppLock/AppLockSettingsScreen/AppLockSettingsScreenViewModel.swift
Show resolved
Hide resolved
|
Shouldn't this page be titled "PIN settings" or something, instead of just Settings, as you'd be going back to Settings? |
# Conflicts: # ElementX.xcodeproj/project.pbxproj # ElementX/Sources/Services/AppLock/AppLockService.swift
pixlwave
force-pushed
the
doug/app-lock-settings
branch
from
9cbd1ec to
10f728c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1917 +/- ##
===========================================
- Coverage 69.09% 69.02% -0.07%
===========================================
Files 483 492 +9
Lines 32995 33232 +237
Branches 16018 16130 +112
===========================================
+ Hits 22797 22939 +142
- Misses 9612 9702 +90
- Partials 586 591 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the App Lock settings screen. This is the screen only, more screens are needed before the flow will work. This branch is based upon #1912.