Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppLockSetupBiometricsScreen. #1942

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 23, 2023

This PR adds the final screen needed to begin working on the app lock flow coordinator.

@pixlwave pixlwave requested a review from a team as a code owner October 23, 2023 14:03
@pixlwave pixlwave requested review from nimau and removed request for a team October 23, 2023 14:03
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9a149ff

@pixlwave pixlwave force-pushed the doug/app-lock-setup-biometrics branch from 7249f40 to ecc907c Compare October 23, 2023 14:05
Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pixlwave pixlwave force-pushed the doug/app-lock-setup-biometrics branch from ecc907c to 9a149ff Compare October 23, 2023 14:49
@pixlwave pixlwave enabled auto-merge (squash) October 23, 2023 14:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (30e6d82) 69.49% compared to head (9a149ff) 69.52%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1942      +/-   ##
===========================================
+ Coverage    69.49%   69.52%   +0.02%     
===========================================
  Files          499      504       +5     
  Lines        33859    34002     +143     
  Branches     16425    16488      +63     
===========================================
+ Hits         23531    23639     +108     
- Misses        9722     9754      +32     
- Partials       606      609       +3     
Flag Coverage Δ
unittests 54.53% <74.64%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckSettingsScreen/AppLockSettingsScreenModels.swift 100.00% <100.00%> (+12.50%) ⬆️
...icsScreen/AppLockSetupBiometricsScreenModels.swift 100.00% <100.00%> (ø)
...ricsScreen/View/AppLockSetupBiometricsScreen.swift 96.61% <96.61%> (ø)
...Screen/AppLockSetupBiometricsScreenViewModel.swift 86.36% <86.36%> (ø)
...ources/Screens/AppLock/Common/LABiometryType.swift 81.25% <81.25%> (ø)
...reen/AppLockSetupBiometricsScreenCoordinator.swift 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave disabled auto-merge October 23, 2023 15:17
@pixlwave pixlwave merged commit 65b7c1d into develop Oct 23, 2023
@pixlwave pixlwave deleted the doug/app-lock-setup-biometrics branch October 23, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants