-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce mandatory app lock outside of the authentication flow. #1982
Conversation
Generated by 🚫 Danger Swift against dfc5023 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1982 +/- ##
===========================================
- Coverage 69.32% 69.19% -0.13%
===========================================
Files 518 518
Lines 35658 35704 +46
Branches 17294 17315 +21
===========================================
- Hits 24719 24707 -12
- Misses 10283 10343 +60
+ Partials 656 654 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
57966a2
to
dfc5023
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was an issue with the mandatory app lock setting where it might not be enforced if:
This PR inserts the flow one final time right at the start of launching the app, showing it before restoring the user's session.