Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce mandatory app lock outside of the authentication flow. #1982

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

pixlwave
Copy link
Member

There was an issue with the mandatory app lock setting where it might not be enforced if:

  • The app crashed or the user force quit after signing in, but before setting a PIN.
  • The setting is retroactively enabled in a new build with existing users (and one day it will be a server-side property so this could be more common than on first appearance).

This PR inserts the flow one final time right at the start of launching the app, showing it before restoring the user's session.

@pixlwave pixlwave requested a review from a team as a code owner October 30, 2023 12:06
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 30, 2023 12:06
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against dfc5023

@pixlwave pixlwave requested review from a team and alfogrillo and removed request for Velin92 and a team October 30, 2023 12:13
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (7ba2e4f) 69.32% compared to head (57966a2) 69.19%.
Report is 2 commits behind head on develop.

❗ Current head 57966a2 differs from pull request most recent head dfc5023. Consider uploading reports for the commit dfc5023 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1982      +/-   ##
===========================================
- Coverage    69.32%   69.19%   -0.13%     
===========================================
  Files          518      518              
  Lines        35658    35704      +46     
  Branches     17294    17315      +21     
===========================================
- Hits         24719    24707      -12     
- Misses       10283    10343      +60     
+ Partials       656      654       -2     
Flag Coverage Δ
unittests 54.24% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ens/Authentication/AuthenticationCoordinator.swift 52.91% <0.00%> (ø)
...urces/Application/AppCoordinatorStateMachine.swift 88.23% <0.00%> (-5.52%) ⬇️
...FlowCoordinators/AppLockSetupFlowCoordinator.swift 32.30% <0.00%> (-1.21%) ⬇️
ElementX/Sources/Application/AppCoordinator.swift 51.53% <0.00%> (-4.19%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave force-pushed the doug/app-lock-mandatory-flow branch from 57966a2 to dfc5023 Compare October 30, 2023 15:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave enabled auto-merge (squash) October 30, 2023 15:19
@pixlwave pixlwave disabled auto-merge October 30, 2023 15:52
@pixlwave pixlwave merged commit e9cdc76 into develop Oct 30, 2023
@pixlwave pixlwave deleted the doug/app-lock-mandatory-flow branch October 30, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants