Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redacted events in timeline #199

Merged
merged 6 commits into from
Sep 21, 2022
Merged

Redacted events in timeline #199

merged 6 commits into from
Sep 21, 2022

Conversation

ismailgulek
Copy link
Contributor

Included redacted events in timeline, with grouping enabled.

Simulator Screen Shot - iPhone 13 Pro Max - 2022-09-21 at 13 45 06

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against ee2d95b

@ismailgulek ismailgulek requested review from a team and stefanceriu and removed request for a team September 21, 2022 10:46
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👏

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aP8Exv

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 11.91% // Head: 11.90% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ee2d95b) compared to base (a88491b).
Patch coverage: 4.89% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #199      +/-   ##
===========================================
- Coverage    11.91%   11.90%   -0.01%     
===========================================
  Files          203      208       +5     
  Lines        13565    14169     +604     
  Branches      6616     6851     +235     
===========================================
+ Hits          1616     1687      +71     
- Misses       11909    12442     +533     
  Partials        40       40              
Impacted Files Coverage Δ
...Kit/Sources/Buttons/ElementActionButtonStyle.swift 0.00% <0.00%> (ø)
...it/Sources/Buttons/ElementCapsuleButtonStyle.swift 0.00% <0.00%> (ø)
ElementX/Sources/AppCoordinator.swift 0.00% <0.00%> (ø)
ElementX/Sources/AppCoordinatorStateMachine.swift 0.00% <ø> (ø)
...mentX/Sources/Generated/Strings+Untranslated.swift 50.00% <ø> (ø)
ElementX/Sources/Other/Extensions/Collection.swift 0.00% <0.00%> (ø)
ElementX/Sources/Other/Extensions/String.swift 0.00% <0.00%> (ø)
ElementX/Sources/Other/Extensions/Task.swift 0.00% <0.00%> (ø)
...tX/Sources/Other/SwiftUI/Views/RoundedCorner.swift 0.00% <0.00%> (ø)
...ens/Authentication/AuthenticationCoordinator.swift 0.00% <ø> (ø)
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ismailgulek ismailgulek merged commit 40e878c into develop Sep 21, 2022
@ismailgulek ismailgulek deleted the ismail/redacted_events branch September 21, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants