Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the App Lock feature. #1990

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Enable the App Lock feature. #1990

merged 2 commits into from
Oct 31, 2023

Conversation

pixlwave
Copy link
Member

The PR removes the feature flag, enabling the feature for everyone.

@pixlwave pixlwave requested a review from a team as a code owner October 30, 2023 18:10
@pixlwave pixlwave requested review from nimau and removed request for a team October 30, 2023 18:10
@github-actions
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 1920099

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a4bf16b) 69.23% compared to head (1920099) 69.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1990      +/-   ##
===========================================
- Coverage    69.23%   69.17%   -0.07%     
===========================================
  Files          518      518              
  Lines        35708    35693      -15     
  Branches     17318    17312       -6     
===========================================
- Hits         24724    24692      -32     
- Misses       10333    10354      +21     
+ Partials       651      647       -4     
Flag Coverage Δ
unittests 54.25% <57.14%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ElementX/Sources/Application/AppSettings.swift 96.82% <ø> (ø)
...erOptionsScreen/DeveloperOptionsScreenModels.swift 0.00% <ø> (ø)
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% <ø> (ø)
...Settings/SettingsScreen/SettingsScreenModels.swift 100.00% <ø> (ø)
...tings/SettingsScreen/SettingsScreenViewModel.swift 81.00% <ø> (-0.91%) ⬇️
...entX/Sources/Services/AppLock/AppLockService.swift 68.11% <ø> (+0.49%) ⬆️
ElementX/Sources/Application/AppCoordinator.swift 51.67% <0.00%> (+0.13%) ⬆️
.../Settings/SettingsScreen/View/SettingsScreen.swift 82.11% <66.66%> (+2.11%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave merged commit af37325 into develop Oct 31, 2023
@pixlwave pixlwave deleted the doug/remove-app-lock-flag branch October 31, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants