Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Xcode 15 #2007

Closed
wants to merge 12 commits into from
Closed

Adopt Xcode 15 #2007

wants to merge 12 commits into from

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 1, 2023 •
edited
Loading

This PR updates the project to be built with Xcode 15. The following has been done:

  • AttributedStringBuilder works with room IDs now (fixed in Converting detected plain text mentions into permalinks #1963).
  • Media processing tests fixed.
  • Preview snapshot tests re-generated, layout fixes applied as necessary. A few caveats:
    • The room screen header is snapshotted as horizontally centred, but in the app its still leading aligned. Not sure I fully understand what is going on here.
    • The waveform icon for an audio message is snapshotted as white, but always shows as iconPrimary in previews.
    • Capsule outlines render with vertical lines in snapshots but are fine on device. Capsule fills have a slight point at either end in snapshots but are fine on device. This is related to rounded corners now defaulting to the .continuous style, but why it renders like this in snapshots is beyond me.
  • Xcode updated in Fastfile
  • UI Tests snapshots re-generated.
    • Same issue with the room screen header, although our tolerances are looser so it was only caught by a single test.
  • Integration tests validated.

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@pixlwave
Fix unit tests and regenerate most snapshots.
2e95dfe
@pixlwave
Tweaks and fixes for snapshots.
cdbb4fc 
Emoji picker

Ignore

Rendering errors - all checked.

More fixes.

Moooar

Debug spacing.

More VStacks.

spacing

Spacing

New icons to fix colouring.

Don't worry about it.

Audio waveform icon renders the wrong colour only in snapshots.

Incorrect header placement but only in snapshots.

Snapshot doesn't load data.

Final fixes.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 71da419

@pixlwave
Revert back to iOS 16 simulator.
44e8bb9 
Revert "Disable PostHog during tests?"
Revert "Try tweak precision for test_appLockSetupBiometricsScreen"
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave mentioned this pull request Nov 14, 2023
Merged
@pixlwave
Copy link
Member Author

Closing this PR as stale. CI was too slow with the iOS 17.0.1 simulator to merge this.

@pixlwave pixlwave closed this Nov 14, 2023
@pixlwave pixlwave deleted the xcode-15 branch November 14, 2023 12:42
@pixlwave pixlwave mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pixlwave