Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression where the forced logout indicator was in the hidden overlay window. #2063

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

pixlwave
Copy link
Member

Given we don't use indicators for anything else on the lock screen, we decided to overlay it directly on top of the screen.

@pixlwave pixlwave requested a review from a team as a code owner November 10, 2023 16:34
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 10, 2023 16:34
Copy link

github-actions bot commented Nov 10, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9311f74

@pixlwave pixlwave force-pushed the doug/fix-lock-screen-sign-out branch from 74c69fd to 9311f74 Compare November 10, 2023 16:47
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave enabled auto-merge (squash) November 10, 2023 17:04
@pixlwave pixlwave disabled auto-merge November 10, 2023 17:20
@pixlwave pixlwave merged commit b5cc2cb into develop Nov 10, 2023
@pixlwave pixlwave deleted the doug/fix-lock-screen-sign-out branch November 10, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants