Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for UI tests now showing the status bar. #2065

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 10, 2023

Now that we've hooked up the window manager, the overlay window is shown in UI tests. This has resulted in all of the screens being presented with the status bar visible. This PR fixes that.

Note: CI failures handled in #2067.

@pixlwave pixlwave requested a review from a team as a code owner November 10, 2023 17:17
@pixlwave pixlwave requested review from stefanceriu and removed request for a team November 10, 2023 17:17
Copy link

github-actions bot commented Nov 10, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against ed5759f

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave pixlwave merged commit a2c2f87 into develop Nov 13, 2023
@pixlwave pixlwave deleted the doug/ui-tests-status-bar branch November 13, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants