-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwiftLint rule to enforce stack spacing. #2080
Conversation
Generated by 🚫 Danger Swift against 8e54c43 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2080 +/- ##
===========================================
- Coverage 69.93% 69.90% -0.03%
===========================================
Files 518 518
Lines 36166 36139 -27
Branches 17525 17510 -15
===========================================
- Hits 25292 25263 -29
- Misses 10223 10224 +1
- Partials 651 652 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Xcode 15 changes the default behaviour and given we're always working from designs, we shouldn't rely on it for our layout.
57a6635
to
3e6bfd9
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
As part of #2007 I noticed that nested stack behaviour has changed when building with the new SDK. Whilst we're still waiting for a solution on the CI side, this PR adds SwiftLint rules to ensure all
HStack
andVStack
s have the spacing parameter (and then goes through the codebase and fixes them by adding spacing and watching the preview to get the right value).Some snapshots have changed as a result of preview stacks and so don't reflect changes in the app. There are some layout changes to the plain timeline style too: