-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ListRow on PollFormScreen. #2183
Conversation
Generated by 🚫 Danger Swift against 8971aa8 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2183 +/- ##
===========================================
+ Coverage 71.31% 71.55% +0.23%
===========================================
Files 516 515 -1
Lines 35235 35242 +7
Branches 16946 16952 +6
===========================================
+ Hits 25127 25216 +89
+ Misses 9486 9401 -85
- Partials 622 625 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
02ab6f9
to
8971aa8
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Looks good! Aside from fixing the bug, does this issue add the Compound list component as the options on this page? |
Yep, this adopts the List component for the entire page. The description wasn't very clear, fixing that bug was just an additional step in this PR to make the whole thing work properly - The options row isn't added to Compound, but is a custom List row (built on-top of Compound) that currently lives inside of the app. |
Updates Compound to fix a bug where the question text field was introspected as a text editor and so not getting the clear button.