Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ListRow on PollFormScreen. #2183

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Use ListRow on PollFormScreen. #2183

merged 4 commits into from
Nov 29, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 28, 2023

Updates Compound to fix a bug where the question text field was introspected as a text editor and so not getting the clear button.

Before After
Screenshot 2023-11-28 at 5 12 53 pm Screenshot 2023-11-28 at 5 44 24 pm

@pixlwave pixlwave requested a review from a team as a code owner November 28, 2023 17:18
@pixlwave pixlwave requested review from alfogrillo and removed request for a team November 28, 2023 17:18
Copy link

github-actions bot commented Nov 28, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 8971aa8

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e749416) 71.31% compared to head (02ab6f9) 71.55%.

❗ Current head 02ab6f9 differs from pull request most recent head 8971aa8. Consider uploading reports for the commit 8971aa8 to get more accurate results

Files Patch % Lines
...Screens/CreatePollScreen/View/PollFormScreen.swift 87.71% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2183      +/-   ##
===========================================
+ Coverage    71.31%   71.55%   +0.23%     
===========================================
  Files          516      515       -1     
  Lines        35235    35242       +7     
  Branches     16946    16952       +6     
===========================================
+ Hits         25127    25216      +89     
+ Misses        9486     9401      -85     
- Partials       622      625       +3     
Flag Coverage Δ
unittests 57.38% <88.13%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave requested a review from callumu November 29, 2023 08:52
Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixlwave pixlwave enabled auto-merge (squash) November 29, 2023 09:31
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@callumu
Copy link

callumu commented Nov 29, 2023

Looks good!

Aside from fixing the bug, does this issue add the Compound list component as the options on this page?

@pixlwave
Copy link
Member Author

pixlwave commented Nov 29, 2023

Yep, this adopts the List component for the entire page. The description wasn't very clear, fixing that bug was just an additional step in this PR to make the whole thing work properly - The options row isn't added to Compound, but is a custom List row (built on-top of Compound) that currently lives inside of the app.

@pixlwave pixlwave merged commit df89e43 into develop Nov 29, 2023
5 checks passed
@pixlwave pixlwave deleted the doug/compound-list branch November 29, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants