Use a VStack on the timeline #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace edge publishers with a binding.
pixlwave
force-pushed
the
doug/timeline-vstack
branch
from
4ea4efb to
80a392f
Compare
Generated by 🚫 Danger Swift against 80a392f |
|
Kudos, SonarCloud Quality Gate passed!
|
pixlwave
commented
Nov 22, 2022
ElementX/Sources/Screens/RoomScreen/View/Timeline/ImageRoomTimelineView.swift
Show resolved
Hide resolved
pixlwave
commented
Nov 22, 2022
Codecov ReportBase: 32.40% // Head: 32.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #332 +/- ##
===========================================
- Coverage 32.40% 32.29% -0.12%
===========================================
Files 266 267 +1
Lines 17530 17593 +63
Branches 9617 9671 +54
===========================================
Hits 5681 5681
- Misses 11677 11738 +61
- Partials 172 174 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from a
LazyVStackto a regularVStackfor the timeline. This fixes various issues seen with the lazy stack not being able to properly estimate its content size (more specifically that is doesn't seem to cache previous item heights as part of this estimate).ReversedScrollViewhas been customised to be specific for the timeline and renamed accordingly.One tradeoff of this change is that memory usage will be higher than a LazyVStack when back paginating a lot in a room. In my testing an heavy amount of back pagination (mainly text items) resulted in around 500MB of memory usage which doesn't seem unworkable, but in the future we could put a limit on the number of items shown and start removing items as you scroll back.