Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop making previews for light & dark colour schemes. #345

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 25, 2022

Xcode 14 now has preview variants for this. Additionally removes some unnecessary @ViewBuilder uses.

@stefanceriu: I've enabled auto-merge on this one so if there are no comments after review GitHub should do it's thing.

Previews using Colour Variants
Screenshot 2022-11-25 at 5 21 25 pm

Xcode 14 now has preview variants for this.
@github-actions
Copy link

github-actions bot commented Nov 25, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 7fff0c0

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave requested review from a team and stefanceriu and removed request for a team November 25, 2022 17:37
@pixlwave pixlwave enabled auto-merge (squash) November 25, 2022 17:40
@pixlwave pixlwave merged commit f776575 into develop Nov 25, 2022
@pixlwave pixlwave deleted the doug/previews branch November 25, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant