Fix keychain access on macOS. #354

pixlwave · 2022-12-06T15:44:53Z

Running ElementX on macOS (Designed for iPad) didn't have the correct access to the App Group for sharing the keychain. This PR adds the Keychain Access Group back to properly support macOS builds.

Note: This PR will require everyone to sign in once again on iOS.

github-actions · 2022-12-06T15:46:14Z

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against dfc749d

stefanceriu

Excellent! 👏 Thank you for taking care of it 👍

codecov · 2022-12-06T16:10:51Z

Codecov Report

Base: 32.47% // Head: 13.70% // Decreases project coverage by -18.77% ⚠️

Coverage data is based on head (e9a8b59) compared to base (7f91852).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head e9a8b59 differs from pull request most recent head dfc749d. Consider uploading reports for the commit dfc749d to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop     #354       +/-   ##
============================================
- Coverage    32.47%   13.70%   -18.78%     
============================================
  Files          245      230       -15     
  Lines        16255    15163     -1092     
  Branches     10035     7444     -2591     
============================================
- Hits          5279     2078     -3201     
- Misses       10814    13027     +2213     
+ Partials       162       58      -104

Flag	Coverage Δ
uitests	`?`
unittests	`13.70% <100.00%> (-0.26%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
ElementX/Sources/Other/InfoPlistReader.swift	`84.84% <100.00%> (+1.51%)`	⬆️
...ources/Services/UserSession/UserSessionStore.swift	`6.60% <100.00%> (ø)`
DesignKit/Sources/Fonts/ElementFonts.swift	`0.00% <0.00%> (-100.00%)`	⬇️
DesignKit/Sources/Fonts/ElementBaseFonts.swift	`0.00% <0.00%> (-100.00%)`	⬇️
...mentX/Sources/UITests/UITestScreenIdentifier.swift	`0.00% <0.00%> (-100.00%)`	⬇️
...mentX/Sources/UITests/UITestsRootCoordinator.swift	`0.00% <0.00%> (-100.00%)`	⬇️
...X/Sources/Screens/Authentication/UIConstants.swift	`0.00% <0.00%> (-100.00%)`	⬇️
...urces/Other/SwiftUI/Views/ElementToggleStyle.swift	`0.00% <0.00%> (-100.00%)`	⬇️
...urces/Other/SwiftUI/Views/RoundedCornerShape.swift	`0.00% <0.00%> (-100.00%)`	⬇️
...s/Other/SwiftUI/Layout/ReadableFrameModifier.swift	`0.00% <0.00%> (-100.00%)`	⬇️
... and 108 more