Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeline day separators and read markers #383

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Dec 21, 2022

Add timeline day separators and read markers as exposed by the RustSDK

Screenshot 2022-12-21 at 15 21 25

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 1d4655d

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 42.66% // Head: 42.52% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (1d4655d) compared to base (a9f2e1b).
Patch coverage: 8.10% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #383      +/-   ##
===========================================
- Coverage    42.66%   42.52%   -0.15%     
===========================================
  Files          247      248       +1     
  Lines        14077    14124      +47     
  Branches      8213     8297      +84     
===========================================
  Hits          6006     6006              
- Misses        7843     7880      +37     
- Partials       228      238      +10     
Flag Coverage Δ
unittests 19.20% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...een/View/Timeline/ReadMarkerRoomTimelineView.swift 0.00% <0.00%> (ø)
...ne/TimelineController/RoomTimelineController.swift 0.00% <0.00%> (ø)
...eline/TimelineItems/RoomTimelineViewProvider.swift 50.84% <0.00%> (-4.71%) ⬇️
...meline/TimelineItems/RoomTimelineViewFactory.swift 55.55% <66.66%> (-6.95%) ⬇️
...reen/View/Timeline/SeparatorRoomTimelineView.swift 66.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanceriu stefanceriu merged commit 131197b into develop Dec 21, 2022
@stefanceriu stefanceriu deleted the stefan/daySeparatorsAndReadMarkers branch December 21, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants