Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the "Failed to load messages" popup when all messages have been loaded #399

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

manuroe
Copy link
Member

@manuroe manuroe commented Jan 4, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against d0d7755

@manuroe manuroe force-pushed the manu/no_more_message_handling branch from 61704f9 to dc0d224 Compare January 4, 2023 09:26
@manuroe manuroe marked this pull request as ready for review January 4, 2023 09:26
@manuroe manuroe requested a review from stefanceriu January 4, 2023 09:27
@stefanceriu stefanceriu enabled auto-merge (rebase) January 4, 2023 09:31
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 42.75% // Head: 42.66% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (dc0d224) compared to base (9ca7f4c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #399      +/-   ##
===========================================
- Coverage    42.75%   42.66%   -0.10%     
===========================================
  Files          248      248              
  Lines        14022    14052      +30     
  Branches      8309     8367      +58     
===========================================
  Hits          5995     5995              
- Misses        7808     7830      +22     
- Partials       219      227       +8     
Flag Coverage Δ
unittests 19.17% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ne/TimelineController/RoomTimelineController.swift 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit 77d62b2 into develop Jan 4, 2023
@stefanceriu stefanceriu deleted the manu/no_more_message_handling branch January 4, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants