Replace completion handlers with async/await. #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against f34b349 |
pixlwave
commented
Jan 5, 2023
pixlwave
force-pushed
the
doug/async-tests
branch
from
aeb891d to
f34b349
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
pixlwave
requested review from
a team and
stefanceriu
and removed request for
a team
Codecov ReportBase: 42.56% // Head: 42.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #407 +/- ##
===========================================
- Coverage 42.56% 42.51% -0.05%
===========================================
Files 248 248
Lines 14091 14091
Branches 8454 8464 +10
===========================================
- Hits 5998 5991 -7
- Misses 7872 7879 +7
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow up to #376 which keeps everything using async/await instead of completion handlers.