Fix back pagination #432
Merged
Fix back pagination #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isBackPaginating and canBackPaginate are updated each time the timeline is rebuilt
Generated by 🚫 Danger Swift against 67a596e |
The top section has gone, which has altered the layout slightly.
pixlwave
force-pushed
the
doug/back-pagination
branch
from
c824116 to
67a596e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
stefanceriu
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pagination logic was broken following a recent change for the SDK, this PR uses the new timeline items for the pagination indicator and the room start to update the view state.
Additionally updates some snapshots that were broken following the removal of the
topsection in the timeline, causing minor layout changes.