Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #437

Merged
merged 7 commits into from
Jan 11, 2023
Merged

Various fixes #437

merged 7 commits into from
Jan 11, 2023

Conversation

stefanceriu
Copy link
Member

  • Fix information leaking in RoomSummaryDetail logs
  • Prevent crash popups when force quitting the application
  • Cleanup crash detection popup display
  • Wait for logout confirmation before changing the app state

@stefanceriu stefanceriu requested a review from pixlwave January 11, 2023 11:11
@github-actions
Copy link

github-actions bot commented Jan 11, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 6d73740

pixlwave
pixlwave reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on soft logout, otherwise looks good to me.

ElementX/Sources/Application/AppCoordinator.swift Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pixlwave
pixlwave approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, that makes sense. LGTM 👍

@stefanceriu stefanceriu merged commit 357d493 into develop Jan 11, 2023
@stefanceriu stefanceriu deleted the stefan/variousFixes branch January 11, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave