-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to logging #457
Conversation
f3086e0
to
a6f7ad8
Compare
Generated by 🚫 Danger Swift against 4871073 |
Tools/Scripts/Templates/SimpleScreenExample/ElementX/TemplateModels.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you for taking care of it! 👏
- Remove old objc logging support. - Fix table view controller.
1559bb9
to
4871073
Compare
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 41.65% // Head: 41.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #457 +/- ##
===========================================
- Coverage 41.65% 41.65% -0.01%
===========================================
Files 264 281 +17
Lines 14976 15236 +260
Branches 9254 9502 +248
===========================================
+ Hits 6239 6347 +108
- Misses 8501 8631 +130
- Partials 236 258 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This PR does the following:
.info
level in most places.MXLog