Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to logging #457

Merged
merged 5 commits into from
Jan 17, 2023
Merged

Improvements to logging #457

merged 5 commits into from
Jan 17, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jan 16, 2023

This PR does the following:

  • Expose more logs to rageshakes by using the .info level in most places.
  • Remove objc support from MXLog
  • Redact message content from logs using CustomStringConvertible.
  • Minor fix to Rust tracing.
  • Fix scroll to bottom button and scroll offset when timeline items update

@github-actions
Copy link

github-actions bot commented Jan 16, 2023

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4871073

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for taking care of it! 👏

UnitTests/Sources/LoggingTests.swift Show resolved Hide resolved
@stefanceriu stefanceriu enabled auto-merge (squash) January 17, 2023 07:37
@stefanceriu stefanceriu disabled auto-merge January 17, 2023 07:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 41.65% // Head: 41.65% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4871073) compared to base (4b56e4a).
Patch coverage: 56.55% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #457      +/-   ##
===========================================
- Coverage    41.65%   41.65%   -0.01%     
===========================================
  Files          264      281      +17     
  Lines        14976    15236     +260     
  Branches      9254     9502     +248     
===========================================
+ Hits          6239     6347     +108     
- Misses        8501     8631     +130     
- Partials       236      258      +22     
Flag Coverage Δ
unittests 20.88% <52.06%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift 46.68% <0.00%> (ø)
...s/AnalyticsPrompt/AnalyticsPromptCoordinator.swift 45.83% <0.00%> (ø)
...hentication/SoftLogout/SoftLogoutCoordinator.swift 16.21% <0.00%> (-0.77%) ⬇️
...urces/Screens/BugReport/BugReportCoordinator.swift 30.23% <0.00%> (ø)
...ojiPickerScreen/EmojiPickerScreenCoordinator.swift 0.00% <0.00%> (ø)
...s/Screens/FilePreview/FilePreviewCoordinator.swift 0.00% <0.00%> (ø)
...reens/OnboardingScreen/OnboardingCoordinator.swift 93.75% <0.00%> (ø)
...s/Screens/RoomDetails/RoomDetailsCoordinator.swift 0.00% <0.00%> (ø)
...ces/Screens/RoomDetails/RoomDetailsViewModel.swift 0.00% <0.00%> (ø)
...ens/RoomMembers/RoomMemberDetailsCoordinator.swift 0.00% <0.00%> (ø)
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave merged commit c893750 into develop Jan 17, 2023
@pixlwave pixlwave deleted the doug/logging branch January 17, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants