Render state items in the timeline and as the last message on the home screen. #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| self.userID = userID | ||
| self.mediaProvider = mediaProvider | ||
| self.attributedStringBuilder = attributedStringBuilder | ||
| self.roomStateStringBuilder = roomStateStringBuilder | ||
| } | ||
|
|
||
| // swiftlint:disable:next cyclomatic_complexity | ||
| func buildTimelineItemFor(eventItemProxy: EventTimelineItemProxy, |
There was a problem hiding this comment.
⚠️ Function body should span 40 lines or less excluding comments and whitespace: currently spans 43 lines (function_body_length)
Generated by 🚫 Danger Swift against 80bb331 |
pixlwave
changed the title
pixlwave
force-pushed
the
stefan/stateEvents
branch
from
a9f98c6 to
ed3ce7d
Compare
pixlwave
force-pushed
the
stefan/stateEvents
branch
from
ed3ce7d to
d3f5bc1
Compare
Codecov ReportBase: 42.50% // Head: 41.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #473 +/- ##
===========================================
- Coverage 42.50% 41.62% -0.88%
===========================================
Files 271 275 +4
Lines 15180 15500 +320
Branches 9631 9880 +249
===========================================
Hits 6452 6452
- Misses 8495 8793 +298
- Partials 233 255 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kudos, SonarCloud Quality Gate passed!
|
stefanceriu
approved these changes
Jan 20, 2023
ElementX/Sources/Services/Timeline/TimelineItems/RoomStateStringBuilder.swift
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItems/RoomStateStringBuilder.swift
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItems/RoomStateStringBuilder.swift
Show resolved
Hide resolved
This was referenced Jan 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
RoomStateStringBuilderwhich will build the right localised strings for state changes.RoomEventStringBuilderwhich will build a localised string for showing events as attributed strings in the room list. This allows us to handle all event types and usesRoomStateStringBuilderfor state events.