Show the date on a room when the last message is older than today. #484

pixlwave · 2023-01-24T08:46:40Z

This PR makes the following changes:

Conditionally formats the timestamp in the room list cell to show different components depending on its age.
Restructures the home screen room cell so that the last message text can expand right to the edge of the cell rather than being compressed by the timestamp text's width.
Adds a hidden 2-line label for the last message to provide consistent cell height that scales with dynamic type.
Makes the last message font weight and colour consistent regardless of read state.
Uses a custom button style for the cells that looks more like an inset UITableView.

Note: Snapshots not updated for UI Tests as @gileluard is going to update the cells again as part of #430.

Pressed State

Fix an issue where the longer the date got the smaller the last message width was.

github-actions · 2023-01-24T08:47:55Z

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 772d464

codecov · 2023-01-24T09:14:31Z

Codecov Report

Base: 41.64% // Head: 41.91% // Increases project coverage by +0.27% 🎉

Coverage data is based on head (772d464) compared to base (7e1593d).
Patch coverage: 64.10% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #484      +/-   ##
===========================================
+ Coverage    41.64%   41.91%   +0.27%     
===========================================
  Files          275      276       +1     
  Lines        15528    15579      +51     
  Branches      9943     9980      +37     
===========================================
+ Hits          6466     6530      +64     
+ Misses        8839     8814      -25     
- Partials       223      235      +12

Flag	Coverage Δ
unittests	`20.93% <19.04%> (+0.43%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...urces/Screens/HomeScreen/HomeScreenViewModel.swift	`59.68% <0.00%> (ø)`
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift	`49.02% <50.00%> (-0.24%)`	⬇️
...s/Screens/HomeScreen/View/HomeScreenRoomCell.swift	`48.36% <58.69%> (-10.84%)`	⬇️
ElementX/Sources/Other/Extensions/Date.swift	`90.90% <90.90%> (ø)`
...ne/TimelineItems/RoomStateEventStringBuilder.swift	`26.03% <0.00%> (+26.03%)`	⬆️