Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode the sliding sync proxy. #502

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Hardcode the sliding sync proxy. #502

merged 7 commits into from
Jan 31, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jan 30, 2023

This PR hard codes the sliding sync proxy to the new matrix.org one for the demo. It removes the proxy input field on server selection (as this won't be needed in the future anyway) and disables the server selection button on the login screen (as no other servers are going to work for now anyway).

Merging this PR is blocked until the Rust SDK has been updated to handle the new JSON response format for sliding sync.

Login Screen
Simulator Screen Shot - iPhone 14 - 2023-01-30 at 12 26 09

@pixlwave pixlwave requested a review from stefanceriu January 30, 2023 12:27
@github-actions
Copy link

github-actions bot commented Jan 30, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️

ElementX/Sources/Services/UserSession/UserSessionStore.swift#L111 - FIXMEs should be resolved (Quick and dirty fix for stoppi...). (todo)

Generated by 🚫 Danger Swift against 7037891

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 40.91% // Head: 41.63% // Increases project coverage by +0.71% 🎉

Coverage data is based on head (ac517d1) compared to base (4f8cc08).
Patch coverage: 71.87% of modified lines in pull request are covered.

❗ Current head ac517d1 differs from pull request most recent head 7037891. Consider uploading reports for the commit 7037891 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #502      +/-   ##
===========================================
+ Coverage    40.91%   41.63%   +0.71%     
===========================================
  Files          289      289              
  Lines        16496    16156     -340     
  Branches     10889    10530     -359     
===========================================
- Hits          6749     6726      -23     
+ Misses        9440     9157     -283     
+ Partials       307      273      -34     
Flag Coverage Δ
unittests 21.27% <49.09%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Other/InfoPlistReader.swift 84.84% <ø> (ø)
ElementX/Sources/Other/Logging/MXLogger.swift 70.51% <0.00%> (ø)
.../Authentication/LoginScreen/View/LoginScreen.swift 67.11% <0.00%> (-0.92%) ⬇️
...cation/ServerSelection/ServerSelectionModels.swift 100.00% <ø> (ø)
...n/ServerSelection/View/ServerSelectionScreen.swift 79.38% <ø> (-6.18%) ⬇️
...urces/Screens/Other/InviteFriendsCoordinator.swift 0.00% <0.00%> (ø)
...Sources/Screens/Settings/View/SettingsScreen.swift 72.58% <0.00%> (ø)
ElementX/Sources/Services/Client/ClientProxy.swift 25.13% <0.00%> (ø)
ElementX/Sources/Other/Extensions/URL.swift 81.81% <50.00%> (ø)
...creens/AnalyticsPrompt/AnalyticsPromptModels.swift 68.18% <50.00%> (ø)
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👌 👌

@pixlwave pixlwave force-pushed the doug/hardcode-proxy-url branch from af59ee4 to be61fc6 Compare January 30, 2023 17:46
@pixlwave
Copy link
Member Author

@stefanceriu be61fc6 adds migrations and bumps the version patch with a migration that signs out the user.

@pixlwave pixlwave force-pushed the doug/hardcode-proxy-url branch from ac517d1 to 7037891 Compare January 31, 2023 17:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave enabled auto-merge (squash) January 31, 2023 17:36
@pixlwave pixlwave merged commit f6629e0 into develop Jan 31, 2023
@pixlwave pixlwave deleted the doug/hardcode-proxy-url branch January 31, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants