Allow different states for the last message. #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against bf0e6fe |
pixlwave
force-pushed
the
doug/last-message-loading
branch
from
df44aa2 to
87b8144
Compare
pixlwave
force-pushed
the
doug/last-message-loading
branch
from
87b8144 to
bf0e6fe
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 41.01% // Head: 21.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #514 +/- ##
============================================
- Coverage 41.01% 21.11% -19.90%
============================================
Files 289 243 -46
Lines 16577 13132 -3445
Branches 10984 5661 -5323
============================================
- Hits 6799 2773 -4026
- Misses 9467 10286 +819
+ Partials 311 73 -238
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to the last message in the room list. It now has 3 states defined in an enum and we choose whether to display the message, a loading placeholder, or a placeholder string when the message is unknown.
Simulator.Screen.Recording.-.iPhone.14.-.2023-02-01.at.16.33.44.mp4