Updated Screenshot Tests and fixed an issue with the MockMediaProvider #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 89db6ad |
… rooms from the mock, and improved some UI tests
Codecov ReportBase: 40.50% // Head: 40.50% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #554 +/- ##
===========================================
- Coverage 40.50% 40.50% -0.01%
===========================================
Files 295 295
Lines 17153 17151 -2
Branches 11441 11433 -8
===========================================
- Hits 6948 6947 -1
+ Misses 9886 9885 -1
Partials 319 319
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ming from the timelineController, also updated some tests, and added a test for the case where the RoomAvatar is available.
pixlwave
approved these changes
Feb 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all the screenshots to adapt to the new designs.
Also fixed an issue that did not fetch an image for the MockMediaProvider to render mocked avatar rooms, and an issue where the roomID was incorrectly using the id of the proxy and not the roomId coming from the timeline