Epic: create and join rooms - Start Chat

[flescio]

Close #592

Add the button for starting the Star Chat flow, the button present the screen with only UI, more login in different tasks

[github-actions]

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0e3e2a6

[pixlwave]

Nice, this is really great first PR to the project 🙌 I see you found all of the form style modifiers. Hope they were self explanatory enough to use.

I'm sure you've noticed Unit tests need implementing, its probably worth pointing out UI tests are the same. Those run nightly so its down to us to remember to check them locally first. Various other comments inline.

One of our aims with the Element X project is to avoid lots of warnings popping up in the sidebar. Ideally if we could avoid merging lots of // TODO: comments this would be better for everyone. I was chatting to Stefan about maybe doing something like // ISSUE:123 instead so that they aren't warnings, but easily searchable and have an associated issue so everyone knows what is needed. Might bring this up on Friday for everyone to chat about :)

[codecov]

Codecov Report

Patch coverage: 1.03% and project coverage change: -0.68 ⚠️

Comparison is base (7eef869) 52.61% compared to head (0e3e2a6) 51.93%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #680      +/-   ##
===========================================
- Coverage    52.61%   51.93%   -0.68%     
===========================================
  Files          265      270       +5     
  Lines        14454    14647     +193     
  Branches      9150     9246      +96     
===========================================
+ Hits          7605     7607       +2     
- Misses        6623     6814     +191     
  Partials       226      226              

Flag	Coverage Δ
unittests	20.92% <1.03%> (-0.27%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...mentX/Sources/Other/AccessibilityIdentifiers.swift	100.00% <ø> (ø)
...ptionsScreen/DeveloperOptionsScreenViewModel.swift	0.00% <0.00%> (ø)
...ionsScreen/View/DeveloperOptionsScreenScreen.swift	0.00% <0.00%> (ø)
...ces/Screens/HomeScreen/HomeScreenCoordinator.swift	75.60% <0.00%> (-3.88%)	⬇️
.../Sources/Screens/HomeScreen/HomeScreenModels.swift	81.25% <0.00%> (-5.42%)	⬇️
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift	60.56% <0.00%> (-4.27%)	⬇️
...urces/Screens/StartChat/StartChatCoordinator.swift	0.00% <0.00%> (ø)
...tX/Sources/Screens/StartChat/StartChatModels.swift	0.00% <0.00%> (ø)
...Sources/Screens/StartChat/StartChatViewModel.swift	0.00% <0.00%> (ø)
...urces/Screens/StartChat/View/StartChatScreen.swift	0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[alfogrillo]

LGTM! 🎉

[pixlwave]

Super, screenshots look 👌. The unit tests are failing due to not having run SwiftFormat. I think you need to run the project setup script to get this to run on commit.

swift run tools setup-project

Then in comparison to EI we have more checks to look at. So please look at fixing the SwiftLint warnings and SonarCloud code smells that would be awesome.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

[pixlwave]

LGTM 😎