Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test plans for all test targets #740

Merged
merged 5 commits into from
Mar 29, 2023
Merged

Add test plans for all test targets #740

merged 5 commits into from
Mar 29, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Mar 28, 2023 •
edited
Loading

This PR adds test plan for the test targets:

  • UnitTests: with "defaultTestExecutionTimeAllowance" : 60
  • IntegrationTests: with the default configuration

@github-actions
Copy link

github-actions bot commented Mar 28, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against f7ed13e

@alfogrillo alfogrillo changed the title Add UnitTests test plan Add test plans for all test targets Mar 29, 2023
@alfogrillo alfogrillo marked this pull request as ready for review March 29, 2023 08:52
@alfogrillo alfogrillo requested a review from a team as a code owner March 29, 2023 08:52
@alfogrillo alfogrillo requested review from pixlwave and removed request for a team March 29, 2023 08:52
pixlwave
pixlwave approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great idea 👍

Maybe worth noting that running the Unit tests when the ElementX scheme is selected doesn't appear to use the test plan, but I don't think that actually matters from the perspective of making sure the right thing happens on CI.

@alfogrillo alfogrillo force-pushed the alfogrillo/unit_tests_test_plan branch from f51e578 to cb2452d Compare March 29, 2023 10:00
@alfogrillo
Copy link
Contributor Author

LGTM, great idea 👍

Maybe worth noting that running the Unit tests when the ElementX scheme is selected doesn't appear to use the test plan, but I don't think that actually matters from the perspective of making sure the right thing happens on CI.

Yeah It doesn't matter, but I think it's still better to be consistent. :)
Applied here.

@pixlwave
Copy link
Member

Nice!

@alfogrillo alfogrillo enabled auto-merge (squash) March 29, 2023 10:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo merged commit f672076 into develop Mar 29, 2023
@alfogrillo alfogrillo deleted the alfogrillo/unit_tests_test_plan branch March 29, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfogrillo @pixlwave