Use iOS localization handling for strings. #803

pixlwave · 2023-04-14T17:31:08Z

Previously we had our own calculatePreferredLanguages method based upon Locale.preferredLanguages to decide suitable languages for strings and then before translating we were doing additional work to manage locale regions if necessary.

Turns out that Bundle has a method called preferredLocalizations which does this for us and makes sure to only provide a single language (plus any regional variations) so you don't end up with the app showing strings in 3 or more languages.

I've removed Bundle.elementFallbackLanguage in favour of the developmentLocalization property, but left in an override so that we can still run unit tests.

There's a run of UI tests going on here, to make sure this works there too

github-actions · 2023-04-14T17:32:32Z

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	ElementX/Sources/Services/BugReport/BugReportService.swift#L82 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (`superfluous_disable_command`)

Generated by 🚫 Danger Swift against 38d40f1

ElementX/Sources/Generated/Strings.swift

codecov · 2023-04-14T18:00:38Z

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.31 ⚠️

Comparison is base (3d0d883) 52.07% compared to head (e02d356) 51.77%.

❗ Current head e02d356 differs from pull request most recent head 38d40f1. Consider uploading reports for the commit 38d40f1 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #803      +/-   ##
===========================================
- Coverage    52.07%   51.77%   -0.31%     
===========================================
  Files          297      297              
  Lines        16544    16528      -16     
  Branches      9923     9914       -9     
===========================================
- Hits          8616     8557      -59     
- Misses        7678     7721      +43     
  Partials       250      250

Flag	Coverage Δ
uitests	`36.46% <44.44%> (-0.02%)`	⬇️
unittests	`25.15% <50.00%> (-0.08%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift	`56.72% <ø> (-3.14%)`	⬇️
...ces/Notification/Manager/NotificationManager.swift	`87.60% <0.00%> (ø)`
.../Sources/Services/BugReport/BugReportService.swift	`69.56% <33.33%> (-0.49%)`	⬇️
ElementX/Sources/Other/Extensions/Bundle.swift	`76.00% <57.14%> (-8.62%)`	⬇️