Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: forget the user’s consents for analytics on logout #816

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Fix: forget the user’s consents for analytics on logout #816

merged 3 commits into from
Apr 21, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Apr 20, 2023

This PR reset the user's consents for analytics on logout (as requested in #106)

@github-actions
Copy link

github-actions bot commented Apr 20, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against f103a45

@nimau nimau force-pushed the nicolas/106-reset-analytics-logout branch from e1ee955 to a6bbc53 Compare April 20, 2023 13:35
@nimau nimau marked this pull request as ready for review April 20, 2023 13:36
@nimau nimau requested a review from a team as a code owner April 20, 2023 13:36
@nimau nimau requested review from stefanceriu and removed request for a team April 20, 2023 13:36
@nimau nimau requested a review from stefanceriu April 21, 2023 14:26
stefanceriu
stefanceriu approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

ElementX/Sources/Services/Analytics/AnalyticsConsentState.swift Outdated Show resolved Hide resolved
ElementX/Sources/Application/AppCoordinator.swift Show resolved Hide resolved
@nimau nimau force-pushed the nicolas/106-reset-analytics-logout branch from 22247d8 to e8b1fec Compare April 21, 2023 14:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nimau nimau requested a review from stefanceriu April 21, 2023 14:51
@nimau nimau enabled auto-merge (squash) April 21, 2023 14:54
@nimau nimau merged commit b432bd6 into develop Apr 21, 2023
@nimau nimau deleted the nicolas/106-reset-analytics-logout branch April 21, 2023 15:05
@pixlwave pixlwave mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu Awaiting requested review from stefanceriu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimau @stefanceriu