Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent room navigation back button from jumping while animating #945

Merged
merged 1 commit into from
May 23, 2023

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner May 23, 2023 13:28
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team May 23, 2023 13:28
@stefanceriu stefanceriu force-pushed the stefan/jumpingBackButton branch from 6b2b0e7 to 51c3f0a Compare May 23, 2023 13:29
@github-actions
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 51c3f0a

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d38cf8f) 48.03% compared to head (51c3f0a) 48.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #945      +/-   ##
===========================================
- Coverage    48.03%   48.03%   -0.01%     
===========================================
  Files          331      331              
  Lines        20538    20537       -1     
  Branches     11307    11306       -1     
===========================================
- Hits          9866     9865       -1     
  Misses       10394    10394              
  Partials       278      278              
Flag Coverage Δ
unittests 22.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 59.61% <ø> (-0.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanceriu stefanceriu merged commit 59f60a1 into develop May 23, 2023
@stefanceriu stefanceriu deleted the stefan/jumpingBackButton branch May 23, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants