Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients that didn't accept verification request should dismiss toast, show accepted in timeline #11964

Closed
bwindels opened this issue Jan 21, 2020 · 1 comment · Fixed by matrix-org/matrix-js-sdk#1163
Assignees

Comments

@bwindels
Copy link
Contributor

bwindels commented Jan 21, 2020

The logic is in place but it's not working probably because the channel is filtering out any events from other devices for the same user. If the request is still pending, we should allow any other device to insert events into the request.

@bwindels
Copy link
Contributor Author

bwindels commented Jan 21, 2020

It doesn't seem to send a .cancel when timing out on the non-accepting client... which is interesting as that could indicate that observeOnly was set and the event from the other device did make it into the request?

The toast stayed open though, with the timeout on the button at 0, so maybe the change event wasn't emitted or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants