Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Modular via config.json #8253

Closed
jryans opened this issue Jan 24, 2019 · 6 comments
Closed

Detect Modular via config.json #8253

jryans opened this issue Jan 24, 2019 · 6 comments

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 24, 2019

For the authentication redesign, we want to know if Riot's default HS is Modular or not. One way to do so would be to state that it is in config.json for Modular installs.

@jryans
Copy link
Collaborator Author

jryans commented Jan 28, 2019

For a Modular-hosted Riot, we will

  • Hide the 3 column server type selector on auth pages
  • Add a note linking to riot.im in case the user was expecting to connect to some other server
  • Skip the Modular server name prompt

@ara4n
Copy link
Member

ara4n commented Jan 28, 2019

I suggest this isn’t done in a modular specific manner, but more: “forceHS”: true or something?

@jryans
Copy link
Collaborator Author

jryans commented Jan 28, 2019

I suggest this isn’t done in a modular specific manner, but more: “forceHS”: true or something?

I went back and forth about this... I agree it's clearer and more future-proof to use settings specific to the desired behavior like you are suggesting.

Originally, I was worried we'd need to pre-select the Modular server type button on Modular-hosted Riots, but since we've decided to entirely hide the server type selector, then yes, I think something like that will work. "forceDefaultHS": true seems to capture the intent.

@jryans
Copy link
Collaborator Author

jryans commented Jan 28, 2019

Filed https://github.com/matrix-org/matrix-hosted/issues/538 to add the extra config setting to Modular-hosted Riots.

@jryans
Copy link
Collaborator Author

jryans commented Jan 28, 2019

Ah, we already have disable_custom_urls, so I think we could continue using this.

@jryans
Copy link
Collaborator Author

jryans commented Feb 20, 2019

Modular now sets disable_custom_urls (which also hides the 3 column selector), so that seems sufficient here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants