Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration spinner doesn't fit in the box #8661

Closed
turt2live opened this issue Feb 14, 2019 · 3 comments
Closed

Registration spinner doesn't fit in the box #8661

turt2live opened this issue Feb 14, 2019 · 3 comments
Assignees
@jryans
Labels
A-Authentication A-Registration P2 S-Tolerable Low/no impact on users T-Defect

Comments

@turt2live
Copy link
Member

image
@jryans
Copy link
Collaborator

jryans commented Feb 15, 2019

Hmm... is that Edge only?

@turt2live
Copy link
Member Author

That was chrome

@bwindels bwindels mentioned this issue Feb 19, 2019
Closed
41 tasks
@jryans jryans self-assigned this Feb 27, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Feb 27, 2019
@jryans
Keep registration spinner inside the auth modal
404c60f 
The spinner was taking on the full height of the modal and escaping off the
page. This keeps it contained inside the modal.

Fixes element-hq/element-web#8661
@jryans jryans mentioned this issue Feb 27, 2019
Merged
@jryans
Copy link
Collaborator

jryans commented Feb 27, 2019

Fixed by matrix-org/matrix-react-sdk#2712

@jryans jryans closed this as completed Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Authentication A-Registration P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @turt2live @lampholder