Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default HS config to match well-known #11112

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Oct 10, 2019

We want to move matrix.org client traffic to https://matrix-client.matrix.org

@erikjohnston
Copy link
Member Author

Two things here:

  1. Its a little bit of a nuisance that riot-web can't just use the standard well-known for a server name.
  2. It would also be nice to have some mechanisms for telling clients they should change where they are talking to, somehow

@erikjohnston erikjohnston requested a review from a team October 10, 2019 13:31
@turt2live
Copy link
Member

Its a little bit of a nuisance that riot-web can't just use the standard well-known for a server name.

We have default_server_name for this

@erikjohnston
Copy link
Member Author

Hmm, the docs say that that is deprecated? Or am I misreading it?

@turt2live
Copy link
Member

it does, but so is the thing riot.im has been serving to users for the last decade. It's deprecated because we would prefer people not use it, but ultimately we don't have a proper plan to remove it yet.

@jryans
Copy link
Collaborator

jryans commented Oct 10, 2019

@turt2live Do you remember why we finally decided to prefer default_server_config style .well-known in Riot over WK from the HS? There's a use case solved by the Riot one, but I am forgetting what it is...

@erikjohnston
Copy link
Member Author

Any particular reason you'd prefer people not to use it? It seems odd to have a deprecated option that matrix.org ends up using

@jryans
Copy link
Collaborator

jryans commented Oct 10, 2019

Indeed... We may want to stop labelling it deprecated if we are going to use it here. Maybe we need to summon @lampholder, as I can't recall if he had one style he'd prefer m.org to use.

@turt2live
Copy link
Member

we labelled it deprecated because we eventually don't want to support a bunch of different ways to define a server config. The default_server_config option was chosen as "best" because it has all the features of the other two that people are likely to care about, but misses the auto-updating part of it. It's also the most reliable if there were to be a server problem.

iirc, modular is (or should be) using the new default_server_config option over the other two.

@jryans
Copy link
Collaborator

jryans commented Oct 10, 2019

We agreed as a group that default_server_name is the best fit for matrix.org's needs.

We should file a separate feature request to track the desire to switch over active sessions with the HS changes.

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll deploy this to develop now.

@jryans jryans merged commit a0599e8 into develop Oct 10, 2019
@jryans
Copy link
Collaborator

jryans commented Oct 11, 2019

Deployed to app / staging as well, looking good. Electron will be updated with the next Riot release (planned for Monday).

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this pull request Oct 23, 2019
This was missed in element-hq/element-web#11112 and causes problems where matrix.org isn't pre-selected.
turt2live added a commit that referenced this pull request Oct 23, 2019
@t3chguy t3chguy deleted the erikj/move_matrix_client branch May 12, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants