Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove draft-js dependency #11616

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Remove draft-js dependency #11616

merged 2 commits into from
Dec 6, 2019

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Dec 6, 2019

...which for some reason was still kicking around

@dbkr
Remove draft-js dependency
e2b1a86 
...which for some reason was still kicking around
@dbkr dbkr requested a review from a team December 6, 2019 13:34
@jryans jryans requested review from jryans and removed request for a team December 6, 2019 13:40
jryans
jryans requested changes Dec 6, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the CSS usage:

https://github.com/vector-im/riot-web/blob/1d495442387478a83e27cfbbd0622f8dee574146/src/vector/index.js#L26

@dbkr
Copy link
Member Author

dbkr commented Dec 6, 2019

Oh, yes - I see what you mean!

@dbkr dbkr merged commit 364e79c into develop Dec 6, 2019
@t3chguy t3chguy deleted the dbkr/why_are_you_still_here_draft_js branch May 12, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @jryans