Remove the code that calls the origin migrator #11631
Conversation
This will have done its job now, everyone's had long enough to install a newer version of Riot and migrate to the new origin. Laves the code on the backend that handles it for the time being, as per comment.
electron_app/src/electron-main.js
Outdated
| // NB. The code to call this has now been removed so this | ||
| // should never be called. This code itself has been removed | ||
| // with the migration to the riot-desktop repo, with the | ||
| // expectation that this will become the new home for this code. |
There was a problem hiding this comment.
Hmm, even after reading this comment, I am still puzzled as to why we're leaving this origin_migrate message handler in place now that nothing calls it... Will we remove it at some future time?
There was a problem hiding this comment.
Sorry, have tried to explain better! We could also just remove the code in both places, it's not actually very invasive.
There was a problem hiding this comment.
Hmm, I guess it just feels strange to remove it half-way like this... What if we end up abandoning the separate repo experiment for some reason? Then we'll be left with this half-way removed thing that we're likely to forget about.
I'd suggest removing the message handler and the module over here as well.
There was a problem hiding this comment.
Fair enough - removed here too
This will have done its job now, everyone's had long enough to
install a newer version of Riot and migrate to the new origin.
Laves the code on the backend that handles it for the time being,
as per comment.