Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jest for tests #11869

Merged
merged 12 commits into from
Jan 16, 2020
Merged

Use Jest for tests #11869

merged 12 commits into from
Jan 16, 2020

Conversation

turt2live
Copy link
Member

Fixes #11291

See commits for a bit of a story to how we got here.

There's a couple things of note that aren't recorded in the diff very well:

  • We bring in canvas for the COLR checks to pass (and upgrade our jsdom environment to pull it in correctly).
  • We use a fake indexeddb so we can do indexeddb things.
  • We have to map some modules to things to fix i18n, the number of copies of react we're running, etc
  • The tests take about 166 seconds to run on my machine (i9-9900k, many RAM) - they surely take longer on CI.

@turt2live turt2live requested a review from a team January 15, 2020 21:59
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
test/app-tests/loading-test.js Outdated Show resolved Hide resolved
@turt2live turt2live merged commit 2652060 into develop Jan 16, 2020
@turt2live turt2live deleted the travis/jest branch January 16, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace tests with Jest
2 participants