Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use debian to build the Docker image #11999

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Use debian to build the Docker image #11999

merged 1 commit into from
Jan 22, 2020

Conversation

turt2live
Copy link
Member

Fixes not having certain OS capabilities to build some packages.

@turt2live
Use debian to build the Docker image
51a9757 
Fixes not having certain OS capabilities to build some packages.
@turt2live turt2live requested a review from a team January 22, 2020 16:08
t3chguy
t3chguy approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume in multistage builds only the final stage layers affect the image size

@turt2live turt2live merged commit 1b8ea4b into develop Jan 22, 2020
@turt2live turt2live deleted the travis/develop-docker branch January 22, 2020 17:04
@turt2live turt2live mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @t3chguy