Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bash in Docker scripts #12001

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Use bash in Docker scripts #12001

merged 1 commit into from
Jan 22, 2020

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jan 22, 2020 •
edited
Loading

Our Docker scripts use Bash-style conditionals that aren't supported by the
default Debian shell.

As a result, we weren't calculating the right branches for the SDKs on develop.

@jryans
Use bash in Docker scripts
b6963d0 
Our Docker scripts use Bash-style conditionals that aren't supported by the
default Debian shell.
@jryans jryans requested a review from a team January 22, 2020 17:46
turt2live
turt2live approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you

@jryans jryans merged commit d7e4784 into develop Jan 22, 2020
@t3chguy t3chguy deleted the jryans/bash-docker branch May 12, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jryans @turt2live