Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Browser checks #12232

Merged
merged 5 commits into from
Feb 5, 2020
Merged

Improve Browser checks #12232

merged 5 commits into from
Feb 5, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 4, 2020 •
edited
Loading

Fixes #12195

  • Updates vendored Modernizr
  • Moves Modernizr dep to dev-dep as we use vendored one and only dev-script needs the node_modules one.
  • Adds custom tests for Object.fromEntries and Promise.prototype.finally
  • Adds extra modernizr rules to make issues like Web interface missing icons #10126 more understandable

jryans
jryans requested changes Feb 4, 2020
View reviewed changes
src/vector/app.js Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member Author

t3chguy commented Feb 4, 2020

image

@t3chguy
Copy link
Member Author

t3chguy commented Feb 5, 2020

image

@t3chguy t3chguy marked this pull request as ready for review February 5, 2020 14:06
@t3chguy t3chguy requested a review from jryans February 5, 2020 14:09
jryans
jryans approved these changes Feb 5, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working on this! 😁

@t3chguy t3chguy merged commit f7e5613 into develop Feb 5, 2020
@t3chguy t3chguy deleted the t3chguy/modernizr branch May 12, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for common unsupported browser issues
2 participants
@t3chguy @jryans