Add review policy doc #12730
Merged
Add review policy doc #12730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I'd like everyone on the team to be aware and provide feedback if they have some, I'll try requesting review from everyone involved. |
t3chguy
approved these changes
Mar 13, 2020
|
@jryans this needs rebasing on develop |
This documents various attributes of our overall review policy from code, design, and product perspectives. Fixes #12614
jryans
force-pushed
the
jryans/review-policy
branch
from
43f6554
to
d930d14
Compare
|
Updated, hopefully should pass CI now. |
turt2live
approved these changes
Mar 13, 2020
|
(we should be avoiding force pushes 😛 - a merge commit for develop -> feature branch is fine) |
Co-Authored-By: Travis Ralston <travpc@gmail.com>
|
Haha, indeed I should re-read and apply the doc to my own thoughts as well 😅 |
turt2live
reviewed
Mar 13, 2020
dbkr
approved these changes
Mar 13, 2020
bwindels
approved these changes
Mar 16, 2020
foldleft
approved these changes
Mar 16, 2020
uhoreg
approved these changes
Mar 16, 2020
Co-Authored-By: Travis Ralston <travpc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents various attributes of our overall review policy from code,
design, and product perspectives.
Rendered
Fixes #12614