Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS for avatars that appear when users are typing #2998

Merged
merged 4 commits into from
Jan 20, 2017
Merged

CSS for avatars that appear when users are typing #2998

merged 4 commits into from
Jan 20, 2017

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Jan 19, 2017 •
edited
Loading

Requires matrix-org/matrix-react-sdk#631
Fixes #2237

Looks like:

screen shot 2017-01-19 at 16 32 34

@ara4n
Copy link
Member

ara4n commented Jan 20, 2017

it needs a 1px solid $primary-bg-color border around the avatar so they overlap nicely; otherwise lgtm. thanks!

@ara4n ara4n assigned lukebarnard1 and unassigned ara4n Jan 20, 2017
@lukebarnard1 lukebarnard1 merged commit a24b568 into develop Jan 20, 2017
@lukebarnard1 lukebarnard1 deleted the luke/css-typing-avatars branch January 20, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @ara4n