fix ImageView Download functionality #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
Whilst I've got used to the 'download' button actually loading things in a new tab, agreed this is a sensible fix - thanks. |
|
lgtm |
This was referenced Apr 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on matrix-org/matrix-react-sdk#802
fixes #2778 and #2970
Notes:
Right clicking "Download this file" and clicking what comes up in Electron lets you send it to Browser/Image Viewer and obviously "Open in new tab" works in browsers. Though this will not work for Encrypted Images in [only] Electron, but will in browsers which support data URIs.