Added default_federate property #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2017
|
I'm interested in reviving this PR. Just needs origin/develop merging back into it to update the base branch |
…lt_federate_by_settings
…ult_federate_by_settings
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…ult_federate_by_settings
…ult_federate_by_settings
|
sorry this has been stuck for so long, and thanks for submitting it. matrix-org/matrix-react-sdk#868 has more details; will merge once 868 lands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows change the default value for
m.federatevalue during the create action. Useful for enviroments where you preferm.federate = Falseasdefaultchoice for the created rooms (see related PR).This PR is embraces the following SPEC: https://docs.google.com/document/d/14zqsbwl5KKil-bB8w2HMhidBVmFkP9Q7EQKFwKIIfZc/edit#heading=h.eipip5qhqo0dOther PR in synapse and matrix-react-sdk and synapse are envolvedSigned-off-by: Pablo Saavedra psaavedra@igalia.com
Related PR:
Edited by Michael to match what the PR actually entails rather than the entire movement that it began as